Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unsupported setup.py calls, cleans up text #4024

Conversation

rlratzel
Copy link
Contributor

@rlratzel rlratzel commented Nov 29, 2023

closes #4008

  • Removes unsupported setup.py calls, which resulted in issue [BUG]: Failed to build from source due to unavailable rapids-dask-dependency #4008 . The document now describes how to use build.sh, which is more consistent with docs for other RAPIDS libs.
  • Removes build.sh output from docs in favor of documenting how to use --help to eliminate the doc being out-of-date with the script.
  • Removes extra wording in places and cleans up various sections.

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 29, 2023
@rlratzel rlratzel added this to the 24.02 milestone Nov 29, 2023
@rlratzel rlratzel self-assigned this Nov 29, 2023
@rlratzel rlratzel requested a review from a team as a code owner November 29, 2023 06:07
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

## Building cuGraph
To install cuGraph from source, ensure the dependencies are met.
You can obtain CUDA from
[https://developer.nvidia.com/cuda-downloads](https://developer.nvidia.com/cuda-downloads).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This points to cuda 12.3.
should it point to the all versions page or maybe 12.0 ? Are we supporting 12.3 ?
Rapids download page only supports up to 12.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It looks like that link was copied from cuDF's version of this page (cc @GregoryKimball ). Instead of trying to keep this page up-to-date, I just linked to the RAPIDS sys requirements page which has the proper download links plus much more relevant info.


## Prerequisites

__Compiler:__
* `gcc` version 9.3+
* `nvcc` version 11.0+
* `cmake` version 3.20.1+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no longer a cmake version requirement?
I get cmake version errors frequently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a cmake dependency, but I changed this doc so that the "prerequisites" section only mentions things not typically installed by our conda dev environment. Since cmake is included in the dev conda environment, I just removed it here for consistency (otherwise it felt like I should also mention make, ninja, cython, etc., etc.)

@rlratzel rlratzel linked an issue Nov 29, 2023 that may be closed by this pull request
2 tasks
@rlratzel
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 6041ab9 into rapidsai:branch-24.02 Nov 29, 2023
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Failed to build from source due to unavailable rapids-dask-dependency
3 participants